[Bug 3293] New: Check if MAX is already defined in memmem.c

bugzilla-daemon at mindrot.org bugzilla-daemon at mindrot.org
Thu Apr 8 11:48:34 AEST 2021


https://bugzilla.mindrot.org/show_bug.cgi?id=3293

            Bug ID: 3293
           Summary: Check if MAX is already defined in memmem.c
           Product: Portable OpenSSH
           Version: 8.5p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: balu.gajjala at gmail.com

defines.h already defined MAX, MIN. It first checks if MAX is not
defined.
In memmem.c, it's assumed MAX is not defined and we define one more
time.

https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/defines.h#L487


https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/openbsd-compat/memmem.c#L64

-- 
You are receiving this mail because:
You are watching the assignee of the bug.


More information about the openssh-bugs mailing list