[Bug 3250] Integer overflow in ConnectTimeout

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3250

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3465|0                           |1
        is obsolete|                            |
                 CC|                            |djm at mindrot.org
   Attachment #3466|                            |ok?(djm at mindrot.org)
              Flags|                            |

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3466
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3466&action=edit
convtime return long -> int

THere a bit more to it than that.  convtime() returns -1 on error
including negative values, but it returns a long.  On a platform where
sizeof(int) != sizeof(long), convtime can accept a large positive value
that then wraps to negative.  I think the correct thing to do is to
change convtime to return int.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.