[Bug 3350] New: Network errors aren't printed logged

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3350

            Bug ID: 3350
           Summary: Network errors aren't printed logged
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: ossman at cendio.se

If you get some kind of network error that breaks your connection, e.g.
ECONNRESET, then this error is never printed to stderr. This is of
course bad as you don't get any information about what actually went
wrong.

The reason is that such errors are buffered and are supposed to be
printed during cleanup of the connection. However earlier in the
cleanup we try to send a disconnect message to the server. This of
course fails (since the connection is dead) and the client bails at
that point.

The last commit that touched this was
23f22a4aaa923c61ec49a99ebaa383656e87fa40, so it might be the culprit.
Or the bug might have been around longer.

Test case:

> [client]$ ssh user at server
> [server]$ sudo ss --kill -t 'sport 22'
> client_loop: send disconnect: Broken pipe

The expected output is:

> Read from remote host server: Connection reset by peer

-- 
You are receiving this mail because:
You are watching the assignee of the bug.