[Bug 3524] New: Rekey interval timeout not working when no package is being transfered

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3524

            Bug ID: 3524
           Summary: Rekey interval timeout not working when no package is
                    being transfered
           Product: Portable OpenSSH
           Version: 8.9p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: sanjeetkaransingh105 at gmail.com

Created attachment 3652
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3652&action=edit
Proposed patch

Description of problem:

Rekey timeout is expiring but rekeying is starting
until a packet is sent or received. 

I tried by ssh -v, and saw even through it reached timeout limit, still
rekeying was not happening until I press any key from keyboard.

Found in Version:
8.9, 8.4.

Proposed fix:

I see there is a check to ensure number of packets should be more than
0, before rekey timeout check inside ssh_packet_need_rekeying func in
packet.c. Just by moving rekey timeout based check before number of
packets check we can fix it.

I have opened a pull request against portable openssh:
https://github.com/openssh/openssh-portable/pull/372

I have attached the patch as well.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.