[Bug 3655] Default ObscureKeystrokeTiming makes X forwarding really slow

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3655

Antonio Larrosa <alarrosa at suse.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alarrosa at suse.com

--- Comment #4 from Antonio Larrosa <alarrosa at suse.com> ---
Created attachment 3837
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3837&action=edit
Patch that fixes the x11 forwarding regression

This patch fixes the issue by not quantising outbound packets as long
as X11 communication happened recently (less than a second ago). The
way I understood it, the purpose of sending chaff packets is to add
traffic when in low traffic situations (like when writing in a shell),
but if there's X11 communications happening, there's already some added
traffic and there's no need to quantise the data sent.

This was tested to fix the issue with the test program in #c2 as well
as when running firefox or other X11 applications which now happen near
instantly again.

This can maybe be improved in several ways, like:
1) adding a boolean variable to the Channel struct that specifies if
it's an x11-connection type that can be quickly tested instead of doing
so many strcmps on Channel's ctype.
2) making lastused a timespec so that subsecond intervals can be tested
correctly.
But I'd like to know the upstream developers opinion on those ideas
before working on that.

Btw, is there some way to submit a Merge/Pull Request to the git
repository? or is adding the patch as an attachment here the proper way
to submit patches?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.