[Bug 3971] Race condition when using ControlMaster=auto with simultaneous connections

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3971

Jens Rosenboom <jens.rosenboom at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3982|0                           |1
        is obsolete|                            |

--- Comment #18 from Jens Rosenboom <jens.rosenboom at web.de> ---
Created attachment 4002
  --> https://bugzilla.mindrot.org/attachment.cgi?id=4002&action=edit
Fix race condition

Hello Ilya Priven,
Thanks for pointing out the issue (that the mux socket was created
although ControlMaster=no).
Would be great if you could check again.

Regarding your further comment:
> Unrelated, did you intend for the original race to remain in the ECONNREFUSED case? With the patch, two clients stumble on stale socket, both unlink it but do not immediately replace with their own socket but rather proceed to try and become masters.

I acknowledge the issue, but would like to keep that separate.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.