[Bug 4047] New: ssh-add: restore explicit wiping of resident-key authenticator PIN

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=4047

            Bug ID: 4047
           Summary: ssh-add: restore explicit wiping of resident-key
                    authenticator PIN
           Product: Portable OpenSSH
           Version: 10.6p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh-add
          Assignee: unassigned-bugs at mindrot.org
          Reporter: tessgauthier at microsoft.com

Created attachment 4018
  --> https://bugzilla.mindrot.org/attachment.cgi?id=4018&action=edit
Patch to restore explicit wiping of the resident-key PIN on success and
failure

load_resident_keys() now deallocates its local FIDO authenticator PIN
with free() rather than explicitly erasing it. This regresses the
cleanup previously provided by the global pass buffer and clear_pass(). 

Relevant commit:
https://github.com/openssh/openssh-portable/commit/3c11ea405486b5ec08f56b7d181ab77e98fdb96b

Before commit 3c11ea405486b5ec08f56b7d181ab77e98fdb96b,
load_resident_keys() stored the PIN in global pass. Its caller in
main() reached done: on both success and failure, where clear_pass()
called freezero(pass, strlen(pass)).

Commit 3c11ea405486b5ec08f56b7d181ab77e98fdb96b ("upstream: bz3635 -
ssh-add -P to skip PIN entry") moved this PIN into local pin and added
ordinary free(pin) on success.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.