[openssh-commits] CVS: fuyu.mindrot.org: openssh

[Darren Tucker]

CVSROOT:        /var/cvs
Module name:    openssh
Changes by:     dtucker at fuyu.mindrot.org 08/06/13 04:46:45

Modified files:
    .               : canohost.c dns.c sshconnect.c

Log message:
   - dtucker at cvs.openbsd.org 2008/06/12 00:03:49
     [dns.c canohost.c sshconnect.c]
     Do not pass "0" strings as ports to getaddrinfo because the lookups
     can slow things down and we never use the service info anyway. bz
     #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi.  ok
     deraadt@ djm@
     djm belives that the reason for the "0" strings is to ensure that
     it's not possible to call getaddrinfo with both host and port being
     NULL.  In the case of canohost.c host is a local array.  In the
     case of sshconnect.c, it's checked for null immediately before use.
     In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
     be non-null but it's not obvious, so I added a warning message in
     case it is ever passed a null.

Diff commands:
cvs -nQq rdiff -u -r1.72 -r1.73 openssh/canohost.c
cvs -nQq rdiff -u -r1.26 -r1.27 openssh/dns.c
cvs -nQq rdiff -u -r1.175 -r1.176 openssh/sshconnect.c

CVSWeb:
http://cvsweb.mindrot.org/index.cgi/openssh/canohost.c?r1=1.72;r2=1.73
http://cvsweb.mindrot.org/index.cgi/openssh/dns.c?r1=1.26;r2=1.27
http://cvsweb.mindrot.org/index.cgi/openssh/sshconnect.c?r1=1.175;r2=1.176

Please note that there may be a delay before commits are available
on the public CVSWeb site.