[openssh-commits] [openssh] 01/01: VALGRIND_CHECK_LEAKS logic was backwards :(

git+noreply at mindrot.org git+noreply at mindrot.org
Wed Jul 11 10:20:18 AEST 2018


This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit fccfa239def497615f92ed28acc57cfe63da3666
Author: Damien Miller <djm at mindrot.org>
Date:   Wed Jul 11 10:19:56 2018 +1000

    VALGRIND_CHECK_LEAKS logic was backwards :(
---
 regress/test-exec.sh     | 2 +-
 regress/valgrind-unit.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/regress/test-exec.sh b/regress/test-exec.sh
index ed235cfa..f09fe0ec 100644
--- a/regress/test-exec.sh
+++ b/regress/test-exec.sh
@@ -164,7 +164,7 @@ if [ "x$USE_VALGRIND" != "x" ]; then
 
 	if [ x"$VG_SKIP" = "x" ]; then
 		VG_LEAK="--leak-check=no"
-		if [ x"$VALGRIND_CHECK_LEAKS" = "x" ]; then
+		if [ x"$VALGRIND_CHECK_LEAKS" != "x" ]; then
 			VG_LEAK="--leak-check=full"
 		fi
 		VG_IGNORE="/bin/*,/sbin/*,/usr/*,/var/*"
diff --git a/regress/valgrind-unit.sh b/regress/valgrind-unit.sh
index c353c2cb..d1c11000 100755
--- a/regress/valgrind-unit.sh
+++ b/regress/valgrind-unit.sh
@@ -9,7 +9,7 @@ test "x$OBJ" = "x" && OBJ=$PWD
 # This mostly replicates the logic in test-exec.sh for running the
 # regress tests under valgrind.
 VG_LEAK="--leak-check=no"
-if [ x"$VALGRIND_CHECK_LEAKS" = "x" ]; then
+if [ x"$VALGRIND_CHECK_LEAKS" != "x" ]; then
 	VG_LEAK="--leak-check=full"
 fi
 VG_TEST=`basename $UNIT_BINARY`

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list