[openssh-commits] [openssh] 05/05: Enable leak checks for unit tests with valgrind

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit 2f6accff5085eb79b0dbe262d8b85ed017d1a51c
Author: Damien Miller <djm at mindrot.org>
Date:   Fri Jul 13 11:39:25 2018 +1000

    Enable leak checks for unit tests with valgrind
    
    Leave the leak checking on unconditionally when running with valgrind.
    The unit tests are leak-free and I want them to stay that way.
---
 regress/valgrind-unit.sh | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/regress/valgrind-unit.sh b/regress/valgrind-unit.sh
index d1c11000..4143ead4 100755
--- a/regress/valgrind-unit.sh
+++ b/regress/valgrind-unit.sh
@@ -7,11 +7,9 @@ UNIT_ARGS="$@"
 test "x$OBJ" = "x" && OBJ=$PWD
 
 # This mostly replicates the logic in test-exec.sh for running the
-# regress tests under valgrind.
-VG_LEAK="--leak-check=no"
-if [ x"$VALGRIND_CHECK_LEAKS" != "x" ]; then
-	VG_LEAK="--leak-check=full"
-fi
+# regress tests under valgrind, except that we unconditionally enable
+# leak checking because the unit tests should be clean.
+VG_LEAK="--leak-check=full"
 VG_TEST=`basename $UNIT_BINARY`
 VG_LOG="$OBJ/valgrind-out/${VG_TEST}.%p"
 VG_OPTS="--track-origins=yes $VG_LEAK --log-file=${VG_LOG}"

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.