[openssh-commits] [openssh] 20/22: upstream: do not leak oprincipals; ok djm

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit 5732d58020309364bf31fa125354e399361006db
Author: markus at openbsd.org <markus at openbsd.org>
Date:   Fri Mar 6 18:28:50 2020 +0000

    upstream: do not leak oprincipals; ok djm
    
    OpenBSD-Commit-ID: 4691d9387eab36f8fda48f5d8009756ed13a7c4c
---
 sshsig.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sshsig.c b/sshsig.c
index 781153fc..15f9cead 100644
--- a/sshsig.c
+++ b/sshsig.c
@@ -881,8 +881,10 @@ cert_filter_principals(const char *path, u_long linenum,
 	oprincipals = principals = *principalsp;
 	*principalsp = NULL;
 
-	if ((nprincipals = sshbuf_new()) == NULL)
-		return SSH_ERR_ALLOC_FAIL;
+	if ((nprincipals = sshbuf_new()) == NULL) {
+		r = SSH_ERR_ALLOC_FAIL;
+		goto out;
+	}
 
 	while ((cp = strsep(&principals, ",")) != NULL && *cp != '\0') {
 		if (strcspn(cp, "!?*") != strlen(cp)) {

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.