[openssh-commits] [openssh] 01/03: Fix memory leak in error path.

git+noreply at mindrot.org git+noreply at mindrot.org
Fri Sep 3 14:39:49 AEST 2021


This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch master
in repository openssh.

commit 1ff38f34b4c4545eb28106629cafa1e0496bc726
Author: Shchelkunov Artem <a.shchelkunov at ideco.ru>
Date:   Wed Aug 11 18:07:58 2021 +0500

    Fix memory leak in error path.
    
    *info is allocated via xstrdup but was leaked in the PAM_AUTH_ERR path.
    From github PR#266.
---
 auth-pam.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/auth-pam.c b/auth-pam.c
index f39d03f4..29034e40 100644
--- a/auth-pam.c
+++ b/auth-pam.c
@@ -886,6 +886,7 @@ sshpam_query(void *ctx, char **name, char **info,
 		case PAM_AUTH_ERR:
 			debug3("PAM: %s", pam_strerror(sshpam_handle, type));
 			if (**prompts != NULL && strlen(**prompts) != 0) {
+				free(*info);
 				*info = **prompts;
 				**prompts = NULL;
 				*num = 0;

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list