[openssh-commits] [openssh] 02/03: upstream: remove incorrect check that can break enrolling a

git+noreply at mindrot.org git+noreply at mindrot.org
Fri Aug 19 16:34:13 AEST 2022


This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit 5453333b5d28e313284cb9aae82899704103f98d
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Fri Aug 19 05:53:28 2022 +0000

    upstream: remove incorrect check that can break enrolling a
    
    resident key (introduced in r1.40)
    
    OpenBSD-Commit-ID: 4cab364d518470e29e624af3d3f9ffa9c92b6f01
---
 sk-usbhid.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sk-usbhid.c b/sk-usbhid.c
index 8f835733..7bc11ccf 100644
--- a/sk-usbhid.c
+++ b/sk-usbhid.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sk-usbhid.c,v 1.42 2022/08/17 06:01:57 djm Exp $ */
+/* $OpenBSD: sk-usbhid.c,v 1.43 2022/08/19 05:53:28 djm Exp $ */
 /*
  * Copyright (c) 2019 Markus Friedl
  * Copyright (c) 2020 Pedro Martelletto
@@ -786,10 +786,6 @@ key_lookup(fido_dev_t *dev, const char *application, const uint8_t *user_id,
 	size_t i;
 
 	memset(message, '\0', sizeof(message));
-	if (pin == NULL) {
-		skdebug(__func__, "NULL pin");
-		goto out;
-	}
 	if ((assert = fido_assert_new()) == NULL) {
 		skdebug(__func__, "fido_assert_new failed");
 		goto out;

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list