[openssh-commits] [openssh] branch master updated (e204b343 -> b30d3215)

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

djm pushed a change to branch master
in repository openssh.

      from  e204b343  restore tty force-read hack
       new  d069b020  upstream: When poll(2) returns -1, for some error conditions
       new  d23b4f7f  upstream: correct comment and use local variable instead of long
       new  c7964fb9  upstream: add a helper for writing an error message to the
       new  754e0d5c  upstream: Add a sshbuf_read() that attempts to read(2) directly in
       new  29a76994  depend
       new  a1a8efea  upstream: Use sshbuf_read() to read directly into the channel input
       new  b30d3215  upstream: add a ssh_packet_process_read() function that reads from

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Detailed log of new commits:

commit b30d32159dc3c7052f4bfdf36357996c905af739
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Sat Jan 22 00:49:34 2022 +0000

    upstream: add a ssh_packet_process_read() function that reads from
    
    a fd directly into the transport input buffer.
    
    Use this in the client and server mainloops to avoid unnecessary
    copying. It also lets us use a more greedy read size without penalty.
    
    Yields a 2-3% performance gain on cipher-speed.sh (in a fairly
    unscientific test tbf)
    
    feedback dtucker@ ok markus@
    
    OpenBSD-Commit-ID: df4112125bf79d8e38e79a77113e1b373078e632

commit a1a8efeaaa9cccb15cdc0a2bd7c347a149a3a7e3
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Sat Jan 22 00:45:31 2022 +0000

    upstream: Use sshbuf_read() to read directly into the channel input
    
    buffer rather than into a stack buffer that needs to be copied again;
    Improves performance by about 1% on cipher-speed.sh feedback dtucker@ ok
    markus@
    
    OpenBSD-Commit-ID: bf5e6e3c821ac3546dc8241d8a94e70d47716572

commit 29a76994e21623a1f84d68ebb9dc5a3c909fa3a7
Author: Damien Miller <djm at mindrot.org>
Date:   Tue Jan 25 11:52:34 2022 +1100

    depend

commit 754e0d5c7712296a7a3a83ace863812604c7bc4f
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Sat Jan 22 00:43:43 2022 +0000

    upstream: Add a sshbuf_read() that attempts to read(2) directly in
    
    to a sshbuf; ok markus@
    
    OpenBSD-Commit-ID: 2d8f249040a4279f3bc23c018947384de8d4a45b

commit c7964fb9829d9ae2ece8b51a76e4a02e8449338d
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Fri Jan 21 07:04:19 2022 +0000

    upstream: add a helper for writing an error message to the
    
    stderr_buf and setting quit_pending; no functional change but saves a bunch
    of boilerplate
    
    OpenBSD-Commit-ID: 0747657cad6b9eabd514a6732adad537568e232d

commit d23b4f7fdb1bd87e2cd7a9ae7c198ae99d347916
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Fri Jan 21 06:58:06 2022 +0000

    upstream: correct comment and use local variable instead of long
    
    indirection; spotted by dtucker@
    
    OpenBSD-Commit-ID: 5f65f5f69db2b7d80a0a81b08f390a63f8845965

commit d069b020a02b6e3935080204ee44d233e8158ebb
Author: deraadt at openbsd.org <deraadt at openbsd.org>
Date:   Fri Jan 21 00:53:40 2022 +0000

    upstream: When poll(2) returns -1, for some error conditions
    
    pfd[].revents is not cleared.  There are subtle errors in various programs.
    In this particular case, the program should error out. ok djm millert
    
    OpenBSD-Commit-ID: 00f839b16861f7fb2adcf122e95e8a82fa6a375c

Summary of changes:
 .depend       |  2 +-
 channels.c    | 50 ++++++++++++++++++++++++++++++-------
 channels.h    |  5 +++-
 clientloop.c  | 79 ++++++++++++++++++++++++++---------------------------------
 packet.c      | 34 +++++++++++++++++++++----
 packet.h      |  3 ++-
 serverloop.c  | 29 ++++++++++------------
 ssh-keyscan.c | 10 +++++---
 sshbuf-misc.c | 39 ++++++++++++++++++++++++++++-
 sshbuf.h      |  6 ++++-
 10 files changed, 174 insertions(+), 83 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.