[openssh-commits] [openssh] 01/01: upstream: bump up loglevel from debug to info when unable to open

git+noreply at mindrot.org git+noreply at mindrot.org
Fri Jul 1 13:55:00 AEST 2022


This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit 4be7184ebe2a2ccef175983517a35ee06766e1b4
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Fri Jul 1 03:52:57 2022 +0000

    upstream: bump up loglevel from debug to info when unable to open
    
    authorized keys/principals file for errno != ENOENT; bz2042 ok dtucker
    
    OpenBSD-Commit-ID: e79aa550d91ade6a80f081bda689da24c086d66b
---
 auth2-pubkeyfile.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/auth2-pubkeyfile.c b/auth2-pubkeyfile.c
index 911f01ba..0cfacac3 100644
--- a/auth2-pubkeyfile.c
+++ b/auth2-pubkeyfile.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-pubkeyfile.c,v 1.2 2022/06/03 04:47:21 djm Exp $ */
+/* $OpenBSD: auth2-pubkeyfile.c,v 1.3 2022/07/01 03:52:57 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  * Copyright (c) 2010 Damien Miller.  All rights reserved.
@@ -449,9 +449,13 @@ auth_openfile(const char *file, struct passwd *pw, int strict_modes,
 	FILE *f;
 
 	if ((fd = open(file, O_RDONLY|O_NONBLOCK)) == -1) {
-		if (log_missing || errno != ENOENT)
-			debug("Could not open %s '%s': %s", file_type, file,
-			    strerror(errno));
+		if (errno != ENOENT) {
+			logit("Could not open user '%s' %s '%s': %s",
+			    pw->pw_name, file_type, file, strerror(errno));
+		} else if (log_missing) {
+			debug("Could not open user '%s' %s '%s': %s",
+			    pw->pw_name, file_type, file, strerror(errno));
+		}
 		return NULL;
 	}
 
@@ -460,7 +464,7 @@ auth_openfile(const char *file, struct passwd *pw, int strict_modes,
 		return NULL;
 	}
 	if (!S_ISREG(st.st_mode)) {
-		logit("User %s %s %s is not a regular file",
+		logit("User '%s' %s '%s' is not a regular file",
 		    pw->pw_name, file_type, file);
 		close(fd);
 		return NULL;

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list