[openssh-commits] [openssh] 01/01: upstream: fix test: getnameinfo returns a non-zero value on error, not

git+noreply at mindrot.org git+noreply at mindrot.org
Mon Mar 27 14:32:11 AEDT 2023


This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit 009eb4cb48a9708ab9174684dcbcc0f942907abe
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Mon Mar 27 03:31:05 2023 +0000

    upstream: fix test: getnameinfo returns a non-zero value on error, not
    
    (neccessarily) -1. From GHPR#384
    
    OpenBSD-Commit-ID: d35e2b71268f66f5543a7ea68751972b3ae22b25
---
 addr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addr.c b/addr.c
index db9ab7ac..fa8c6692 100644
--- a/addr.c
+++ b/addr.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: addr.c,v 1.6 2022/10/28 02:29:34 djm Exp $ */
+/* $OpenBSD: addr.c,v 1.7 2023/03/27 03:31:05 djm Exp $ */
 
 /*
  * Copyright (c) 2004-2008 Damien Miller <djm at mindrot.org>
@@ -443,7 +443,7 @@ addr_ntop(const struct xaddr *n, char *p, size_t len)
 	if (p == NULL || len == 0)
 		return -1;
 	if (getnameinfo(_SA(&ss), slen, p, len, NULL, 0,
-	    NI_NUMERICHOST) == -1)
+	    NI_NUMERICHOST) != 0)
 		return -1;
 
 	return 0;

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list