[openssh-commits] [openssh] branch master updated: Comment out atime restore test.

git+noreply at mindrot.org git+noreply at mindrot.org
Sat Aug 2 12:52:59 AEST 2025


This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch master
in repository openssh.

The following commit(s) were added to refs/heads/master by this push:
     new e85248df3 Comment out atime restore test.
e85248df3 is described below

commit e85248df3f1073343da87a6b00512e6a1e4a863d
Author: Darren Tucker <dtucker at dtucker.net>
AuthorDate: Sat Aug 2 12:51:42 2025 +1000

    Comment out atime restore test.
    
    This works on filesystems mounted 'noatime', but on others the stat()
    resets atime causing the test to fail.
---
 openbsd-compat/regress/utimensattest.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/openbsd-compat/regress/utimensattest.c b/openbsd-compat/regress/utimensattest.c
index bbc66c485..b4405e464 100644
--- a/openbsd-compat/regress/utimensattest.c
+++ b/openbsd-compat/regress/utimensattest.c
@@ -77,11 +77,17 @@ main(void)
 		fail("utimensat", 0, 0);
 
 	if (stat(TMPFILE, &sb) == -1)
-		fail("stat", 0, 0 );
+		fail("stat", 0, 0);
+#if 0
+	/*
+	 * This test only works on filesystems mounted 'noatime', otherwise the
+	 * stat() above resets atime. Skip by default.
+	 */
 	if (sb.st_atime != 12345678)
-		fail("st_atime", 0, 0 );
+		fail("st_atime", 0, 0);
+#endif
 	if (sb.st_mtime != 34567890)
-		fail("st_mtime", 0, 0 );
+		fail("st_mtime", 0, 0);
 #if 0
 	/*
 	 * Results expected to be rounded to the nearest microsecond.

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list