[openssh-commits] [openssh] 03/03: upstream: unit tests for convtime_double()

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

commit f4e79a4ba91cf0fd7397846424d1b261f3648708
Author: djm at openbsd.org <djm at openbsd.org>
AuthorDate: Fri Dec 5 07:43:24 2025 +0000

    upstream: unit tests for convtime_double()
    
    OpenBSD-Regress-ID: d3ba7b894019b4128845d638c78fca37b3b6eecf
---
 regress/unittests/misc/test_convtime.c | 37 +++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/regress/unittests/misc/test_convtime.c b/regress/unittests/misc/test_convtime.c
index 4fdcf3812..83af8c8c8 100644
--- a/regress/unittests/misc/test_convtime.c
+++ b/regress/unittests/misc/test_convtime.c
@@ -1,4 +1,4 @@
-/* 	$OpenBSD: test_convtime.c,v 1.3 2022/08/11 01:57:50 djm Exp $ */
+/* 	$OpenBSD: test_convtime.c,v 1.4 2025/12/05 07:43:24 djm Exp $ */
 /*
  * Regress test for misc time conversion functions.
  *
@@ -57,6 +57,41 @@ test_convtime(void)
 #endif
 	TEST_DONE();
 
+	TEST_START("misc_convtime_double");
+	ASSERT_DOUBLE_EQ(convtime_double("0"), 0);
+	ASSERT_DOUBLE_EQ(convtime_double("1"), 1.0);
+	ASSERT_DOUBLE_EQ(convtime_double("2s"), 2.0);
+	ASSERT_DOUBLE_EQ(convtime_double("3m"), 180.0);
+	ASSERT_DOUBLE_EQ(convtime_double("1m30s"), 90.0);
+	ASSERT_DOUBLE_EQ(convtime_double("1.5s"), 1.5);
+	ASSERT_DOUBLE_EQ(convtime_double(".5s"), 0.5);
+	ASSERT_DOUBLE_EQ(convtime_double("0.5s"), 0.5);
+	ASSERT_DOUBLE_EQ(convtime_double("1.123456s"), 1.123456);
+	ASSERT_DOUBLE_EQ(convtime_double("1.1234567s"), 1.1234567);
+	ASSERT_DOUBLE_EQ(convtime_double("1.123s"), 1.123);
+	ASSERT_DOUBLE_EQ(convtime_double("1m0.5s"), 60.5);
+	ASSERT_DOUBLE_EQ(convtime_double("1m.5s"), 60.5);
+	ASSERT_DOUBLE_EQ(convtime_double("1.5"), 1.5);
+	ASSERT_DOUBLE_EQ(convtime_double("1.123456"), 1.123456);
+	ASSERT_DOUBLE_EQ(convtime_double("1.1234567"), 1.1234567);
+	/* errors */
+	ASSERT_DOUBLE_LT(convtime_double(""), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("trout"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.s"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("0x1"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("inf"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("nan"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1e10"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("-1"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("3.w0.5s"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.0d0.5s"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.5m"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.5h"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.5d"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1.5w"), 0.0);
+	ASSERT_DOUBLE_LT(convtime_double("1s1.5"), 0.0);
+	TEST_DONE();
+
 	/* XXX timezones/DST make verification of this tricky */
 	/* XXX maybe setenv TZ and tzset() to make it unambiguous? */
 	TEST_START("misc_parse_absolute_time");

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.