[openssh-commits] [openssh] branch master updated: Try to fix github tcmalloc target failure

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

djm pushed a commit to branch master
in repository openssh.

The following commit(s) were added to refs/heads/master by this push:
     new 3bc6de98 Try to fix github tcmalloc target failure
3bc6de98 is described below

commit 3bc6de98c830bd5207f6c371ba69c5874f06305b
Author: Damien Miller <djm at mindrot.org>
AuthorDate: Mon Feb 24 17:27:50 2025 +1100

    Try to fix github tcmalloc target failure
    
    tcmalloc may, depending on the stacktrace generator it uses, create
    pipe(2) fds during shared library initialisation. These will later
    get clobbered by ssh/sshd calling closefrom() and chaos will ensue.
    Tell tcmalloc to use an unwinder that doesn't pull this stuff.
---
 .github/configs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.github/configs b/.github/configs
index bcb67365..51b5b1e1 100755
--- a/.github/configs
+++ b/.github/configs
@@ -136,6 +136,12 @@ case "$config" in
 	;;
     tcmalloc)
 	CONFIGFLAGS="--with-ldflags=-ltcmalloc"
+	# tcmalloc may, depending on the stacktrace generator it uses, create
+	# pipe(2) fds during shared library initialisation. These will later
+	# get clobbered by ssh/sshd calling closefrom() and chaos will ensue.
+	# Tell tcmalloc to use an unwinder that doesn't pull this stuff.
+	TCMALLOC_STACKTRACE_METHOD=generic_fp
+	export TCMALLOC_STACKTRACE_METHOD
 	;;
     krb5|heimdal)
 	CONFIGFLAGS="--with-kerberos5"

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.