[openssh-commits] [openssh] 02/03: upstream: Don't leak the args list. Coverity CIDs 481569 & 481570,

git+noreply at mindrot.org git+noreply at mindrot.org
Fri May 23 21:49:15 AEST 2025


This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch master
in repository openssh.

commit f097d7bd07da4634c1a723d1dc4fcf56e7d0e147
Author: dtucker at openbsd.org <dtucker at openbsd.org>
AuthorDate: Fri May 23 09:26:25 2025 +0000

    upstream: Don't leak the args list. Coverity CIDs 481569 & 481570,
    
    ok job@ tb at .
    
    OpenBSD-Commit-ID: becabcd00513d13d1435b68b7ccffa7151b72393
---
 scp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scp.c b/scp.c
index 57c242ffc..ab8ab2295 100644
--- a/scp.c
+++ b/scp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: scp.c,v 1.263 2025/03/28 06:04:07 dtucker Exp $ */
+/* $OpenBSD: scp.c,v 1.264 2025/05/23 09:26:25 dtucker Exp $ */
 /*
  * scp - secure remote copy.  This is basically patched BSD rcp which
  * uses ssh to do the data transfer (instead of using rcmd).
@@ -1224,6 +1224,7 @@ toremote(int argc, char **argv, enum scp_mode_e mode, char *sftp_direct)
 out:
 	if (mode == MODE_SFTP)
 		free(conn);
+	freeargs(&alist);
 	free(tuser);
 	free(thost);
 	free(targ);
@@ -1306,6 +1307,7 @@ tolocal(int argc, char **argv, enum scp_mode_e mode, char *sftp_direct)
 		(void) close(remin);
 		remin = remout = -1;
 	}
+	freeargs(&alist);
 	free(suser);
 	free(host);
 	free(src);

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list