[openssh-commits] [openssh] 05/10: upstream: clarify intent and avoid (harmess, defined behaviour)
git+noreply at mindrot.org
git+noreply at mindrot.org
Thu Sep 25 17:02:36 AEST 2025
This is an automated email from the git hooks/post-receive script.
djm pushed a commit to branch master
in repository openssh.
commit b62aa85dcbc8f03bf91d26d14fbf8fd5e172d882
Author: djm at openbsd.org <djm at openbsd.org>
AuthorDate: Thu Sep 25 06:25:38 2025 +0000
upstream: clarify intent and avoid (harmess, defined behaviour)
unsigned underflow. ok tb@
OpenBSD-Commit-ID: b73bf5f1f381c3e4561a6cc706fb1cd77c939cd8
---
ssh-keysign.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/ssh-keysign.c b/ssh-keysign.c
index c2d8471ad..8d6bcda10 100644
--- a/ssh-keysign.c
+++ b/ssh-keysign.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-keysign.c,v 1.77 2025/08/29 03:50:38 djm Exp $ */
+/* $OpenBSD: ssh-keysign.c,v 1.78 2025/09/25 06:25:38 djm Exp $ */
/*
* Copyright (c) 2002 Markus Friedl. All rights reserved.
*
@@ -129,8 +129,10 @@ valid_request(struct passwd *pw, char *host, struct sshkey **ret, char **pkalgp,
/* client host name, handle trailing dot */
if ((r = sshbuf_get_cstring(b, &p, &len)) != 0)
fatal_fr(r, "parse hostname");
- debug2_f("check expect chost %s got %s", host, p);
- if (strlen(host) != len - 1)
+ debug2_f("check expect chost \"%s\" got \"%s\"", host, p);
+ if (len == 0)
+ fail++;
+ else if (strlen(host) != len - 1)
fail++;
else if (p[len - 1] != '.')
fail++;
--
To stop receiving notification emails like this one, please contact
djm at mindrot.org.
More information about the openssh-commits
mailing list