[openssh-commits] [openssh] branch V_10_2 updated: fix duplicate PAM msgs, missing loginmsg reset

[git+noreply at mindrot.org]

This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch V_10_2
in repository openssh.

The following commit(s) were added to refs/heads/V_10_2 by this push:
     new 3d3ee425b fix duplicate PAM msgs, missing loginmsg reset
3d3ee425b is described below

commit 3d3ee425b61c7a1511a996ff27f3c807243afd49
Author: Matthew Heller <hellermf at accre.vanderbilt.edu>
AuthorDate: Mon Oct 14 09:25:41 2024 -0500

    fix duplicate PAM msgs, missing loginmsg reset
    
    without this change in mm_answer_pam_account all messages added in
    auth-pam.c sshpam_query(...) case PAM_SUCCESS end up sent here, then are
    still sitting in the loginmsg buffer and printed a second time in
    session.c do_login(...)
---
 monitor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/monitor.c b/monitor.c
index a9e854bec..ad086c300 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1129,6 +1129,7 @@ mm_answer_pam_account(struct ssh *ssh, int sock, struct sshbuf *m)
 	if ((r = sshbuf_put_u32(m, ret)) != 0 ||
 	    (r = sshbuf_put_stringb(m, loginmsg)) != 0)
 		fatal_fr(r, "buffer error");
+	sshbuf_reset(loginmsg);
 
 	mm_request_send(sock, MONITOR_ANS_PAM_ACCOUNT, m);
 

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.