[openssh-commits] [openssh] branch master updated: upstream: Avoid printf("%s", NULL) since it's not guaranteed to be safe

git+noreply at mindrot.org git+noreply at mindrot.org
Wed Jun 24 22:00:51 AEST 2026


This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch master
in repository openssh.

The following commit(s) were added to refs/heads/master by this push:
     new aa60cf3f4 upstream: Avoid printf("%s", NULL) since it's not guaranteed to be safe
aa60cf3f4 is described below

commit aa60cf3f41e89530448a720e08ec31a6d8ffd79e
Author: dtucker at openbsd.org <dtucker at openbsd.org>
AuthorDate: Wed Jun 24 11:59:09 2026 +0000

    upstream: Avoid printf("%s", NULL) since it's not guaranteed to be safe
    
    and will segfault on some -portable platforms.
    
    OpenBSD-Commit-ID: b49d588f8becf6363305aac42d7d9660fc7fe3ba
---
 channels.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/channels.c b/channels.c
index 5d0b8ca52..fcd80288f 100644
--- a/channels.c
+++ b/channels.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: channels.c,v 1.462 2026/06/24 06:53:57 djm Exp $ */
+/* $OpenBSD: channels.c,v 1.463 2026/06/24 11:59:09 dtucker Exp $ */
 /*
  * Author: Tatu Ylonen <ylo at cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo at cs.hut.fi>, Espoo, Finland
@@ -365,7 +365,7 @@ channel_classify(struct ssh *ssh, Channel *c)
 
 	c->bulk = type != NULL && match_pattern_list(type, classifier, 0) == 1;
 	debug3("channel %d: classify type \"%s\" (%s) as %s", c->self,
-	    type, has_tty ? "with TTY" : "no TTY",
+	    type ? type : "(null)", has_tty ? "with TTY" : "no TTY",
 	    c->bulk ? "bulk" : "interactive");
 }
 

-- 
To stop receiving notification emails like this one, please contact
djm at mindrot.org.


More information about the openssh-commits mailing list