Suggestion: login.c->record_login()

[Andre Lucas]

Damien Miller wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Mon, 27 Dec 1999, Andre Lucas wrote:
> 
> > Hi,
> >
> > A lot of the problems with openssh portability so far appear to
> > be with the login record functionality, i.e. lastlog support, and
> > variations on handling utmp vs. utmpx etc. Looking at for-profit SSH
> > 1.2.27, login.c is rather embarassing spaghetti code, so laden with
> > '#ifdef's it's almost impossible to read.
> 
> No kidding :) The login portions of OpenSSH have, so far, proved to
> be the most platform dependant.

Ok, it was stating the obvious somewhat :-)

> <snip>

> > It's still not exactly pretty, but it's a lot more readily understood
> > IMO. (I've left error propogation out for clarity at this point.)
> 
> I think this is an excellent idea. If it works well, then it could
> also serve as the basis for solving this problem for other projects.

I thought that too. It's real hassleware, but some poor soul has to do
it!

> 
> <snip> 
> 
> > I'm aware that there are issues for Damien here in keeping track of
> > OpenBSD changes to the OpenSSH codebase. I still think that this
> > would be tidier and easier in the long run.
> 
> I would be happier sacrificing easy 'diffability' on one source file
> in return for better code.

Ah, if only people at my work thought that way...

Ta,
-Andre

> 
> login.c is hardly ever touched by the OpenBSD people, the last real
> change to it was in August. Keeping track of this pace of change
> will not be a problem :)
> 
> My goal is to have a 1.2.1.0 release before, or shortly after the
> new year. I think that major surgery to the login code should wait
> until after then.

> 
> Regards,
> Damien
> 
> - --
> | "Bombay is 250ms from New York in the new world order" - Alan Cox
> | Damien Miller - http://www.mindrot.org/
> | Email: djm at mindrot.org (home) -or- djm at ibs.com.au (work)
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.0 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
> 
> iD8DBQE4Z/z5ormJ9RG1dI8RAkdKAKCO2XzYtXq2yUuj9ob9p5Msvz+WZwCeL7g+
> BeXnqHdlDlFtd1GOzPRYyhA=
> =dXL1
> -----END PGP SIGNATURE-----