3 Bugs to Report: OpenSSH V1.2pre13

[Damien Miller]

On Sun, 21 Nov 1999, Robert Hardy wrote:

> Three possibly related bugs to report. N.B.  The test machines in question
> are in peak form (with the exception of different kernel versions) and were
> working 100% under the old ssh 1.2.x.  The two clients we tested from are
> machines running 2.2.13 & 2.2.14preX Linux kernels. The server where the
> problems appeared is running 2.2.12.
> 
> 1. sshd dies periodically. The crash occurred just after a connect

Can you try the following patch and tell me if it makes a difference?

Index: helper.c
===================================================================
RCS file: /var/cvs/openssh/helper.c,v
retrieving revision 1.6
diff -u -r1.6 helper.c
--- helper.c	1999/11/22 02:55:36	1.6
+++ helper.c	1999/11/22 03:59:24
@@ -130,9 +129,12 @@
 
 #endif /* HAVE_EGD */
 
-	c = read(random_pool, buf, len);
-	if (c == -1)
-		fatal("Couldn't read from random pool \"%s\": %s", RANDOM_POOL, strerror(errno));
+	do {
+		c = read(random_pool, buf, len);
+
+		if ((c == -1) && (errno != EINTR))
+			fatal("Couldn't read from random pool \"%s\": %s", RANDOM_POOL, strerror(errno));
+	} while (c == -1);
 
 	if (c != len)
 		fatal("Short read from random pool \"%s\"", RANDOM_POOL);

 
> 2. sshd will sometimes hang when disconnecting from a server. 
>    -ssh host
>    -we do some work
>    -we hit CTRL-D to disconnect
>    -we logout on remote system
>    -ssh does not disconnect from remote system and will stay hung indefinitely
>     (an ps -axuww shows an sshd process still running on the pty.)

Any ideas on how to trigger the hang?

> I am willing to test various things to try and help isolate the problem(s). 
> I'm open to suggestions...

If you can be bothered, a gdb trace of problem #2 from the client and
server would be a godsend.

Regards,
Damien
 

--
| "Bombay is 250ms from New York in the new world order" - Alan Cox
| Damien Miller - http://www.mindrot.org/
| Email: djm at mindrot.org (home) -or- djm at ibs.com.au (work)