PrintLastLog option is not honored

Pekka Savola pekkas at netcore.fi
Thu Dec 28 09:45:03 EST 2000


On Wed, 27 Dec 2000, Christian Kurz wrote:

> here's another bug report against openssh with a patch included (from
> the same person who submitted the bug report). Would you please apply
> it? Thanks!

Umm.. There is no print_lastlog option in OpenSSH base/portable.
Perhaps you should supply the actual patch too ;-)

> > The Debian package of ssh includes patches to recognize a 'PrintLastLog'
> > option which can be used to disable the automatic display of the last
> > login time.  (This is often handled by PAM.)  The option is scanned and
> > converted to a flag variable, but that flag variable is never examined,
> > so the patch does no good.
>
> |--- openssh-2.2.0p1/session.c   Tue Aug 29 15:21:22 2000
> |+++ openssh-2.2.0p1z/session.c  Mon Sep 18 09:55:01 2000
> |@@ -686,7 +686,7 @@
> |         */
> |        last_login_time = get_last_login_time(pw->pw_uid, pw->pw_name,
> |            buf, sizeof(buf));
> |-       if (last_login_time != 0) {
> |+       if (last_login_time != 0 && options.print_lastlog) {
> |                time_string = ctime(&last_login_time);
> |                if (strchr(time_string, '\n'))
> |                        *strchr(time_string, '\n') = 0;
>
> Ciao
>      Christian
>

-- 
Pekka Savola                    "Tell me of difficulties surmounted,
Netcore Oy                      not those you stumble over and fall"
Systems. Networks. Security.     -- Robert Jordan: A Crown of Swords






More information about the openssh-unix-dev mailing list