problems compiling 1.2.2 on HP-UX 10.20 (gcc)

[Andre Lucas]

On Fri, Feb 04, 2000 at 03:15:39PM +0000, Will Partain wrote:
> The problem seems to be that if you #include <utmpx.h>
> without suitable -DPOSIX_SOMETHING magic, you get no struct
> utmpx (all that stuff is wrapped w/ "#ifdef
> _INCLUDE_XOPEN_SOURCE_EXTENDED").
> 
> I'm not sure how you all are handling such portability
> issues.  Thx,
> 

Send 'em in! In this case though, it isn't a portability issue. It's not
a problem with utmpx.h, it's a typo in login.c. A patch is attached.

The login stuff is really system dependent, hence the profusion of
'#ifdef's. Efforts are under way to clean it up.

8<
> login.c:236: conflicting types for `login'
> bsd-login.h:12: previous declaration of `login'
> login.c:236: warning: data definition has no type or storage class
> make: *** [login.o] Error 1
> ourmake failed

Damien, is it time for a FAQ yet ;-)

Ta,
-Andre

-- 
Andre Lucas <andre.lucas at dial.pipex.com>
http://dspace.dial.pipex.com/andre.lucas/



--- openssh-1.2.2/login.c	Wed Jan 26 00:04:48 2000
+++ openssh-1.2.2.new/login.c	Fri Jan 28 14:59:56 2000
@@ -210,7 +210,7 @@
 #  endif /* HAVE_SYSLEN_IN_UTMPX */
 # endif
 #if defined(HAVE_ADDR_IN_UTMPX)
-	if (addr)
+	if (addr) {
 		switch (addr->sa_family) {
 			case AF_INET: {
 				struct sockaddr_in *in = (struct sockaddr_in*)addr;