openssh-SNAP-20001016

[Markus Friedl]

On Fri, Oct 27, 2000 at 03:48:13PM +0200, Gert Doering wrote:
> userauth_reply(Authctxt *authctxt, int authenticated)
> {
>         /* XXX todo: check if multiple auth methods are needed */
>         if (authenticated == 1) {
> #ifdef WITH_AIXAUTHENTICATE
>                 /* We don't have a pty yet, so just label the line as "ssh" */
>                 if (loginsuccess(user, get_canonical_hostname(), "ssh",

s/user/authctxt->pw->pw_name/

>                                &aixloginmsg) < 0)
>                         aixloginmsg = NULL;
> #endif /* WITH_AIXAUTHENTICATE */
> 
> 
> looking what "user" should be here, I find worse things in the other 
> place related to AIXAUTHENTICATE:
> 
> 
> input_userauth_request(int type, int plen, void *ctxt)
> {
>         Authctxt *authctxt = ctxt;
>         Authmethod *m = NULL;
>         char *user, *service, *method;
>         int authenticated = 0;
> 
>         if (authctxt == NULL)
>                 fatal("input_userauth_request: no authctxt");
>         if (authctxt->attempt++ >= AUTH_FAIL_MAX) {
> #ifdef WITH_AIXAUTHENTICATE
>                 loginfailed(user,get_canonical_hostname(),"ssh");

s/user/authctxt->user ? authctxt->user : "<nouser>"/

> #endif /* WITH_AIXAUTHENTICATE */
>                 packet_disconnect("too many failed userauth_requests");
>        }
> 
>         user = packet_get_string(NULL);
>         service = packet_get_string(NULL);
>         method = packet_get_string(NULL);

-m