Problem with latest OpenSSH - 2.5.2p2

[Wayne Davison]

> On Mon, Apr 16, 2001 at 10:15:44AM -0700, Wayne Davison wrote:
> > It looks like atomicio() hard-loops on EAGAIN and EWOULDBLOCK.
> > Shouldn't it have something like the following? [...select code...]

On Tue, 17 Apr 2001, Markus Friedl wrote:
> no. just return on EAGAIN.

Why do you say that?  That's not what the callers of atomicio() are
expecting.  They're expecting the entire specified number of bytes to
be read/written, and only a real error should stop it from completing
this.  If you are talking about the read() call that was being tweaked
in client_process_input(), you're right that that doesn't need to loop
on EAGAIN (nor does it expect to completely fill the specified read
buffer size), and thus it would be wrong to make it use atomicio().

..wayne..