Cray patch against openssh-SNAP-20010802

[Tim Rice]

On Tue, 7 Aug 2001, William L. Jones wrote:

>
>
> > -----Original Message-----
> > From: owner-openssh-unix-dev at mindrot.org
> > [mailto:owner-openssh-unix-dev at mindrot.org]On Behalf Of Tim Rice
> > Sent: Monday, August 06, 2001 9:29 PM
> > To: William L. Jones
> > Cc: openssh-unix-dev at mindrot.org
> > Subject: RE: Cray patch against openssh-SNAP-20010802
> >
> >
> > On Mon, 6 Aug 2001, William L. Jones wrote:
> >
> > >
> > > Two problems.  Their an " just after fatal that I don't think should be
> > > their
> >
> > Ah yes, I see the extra "
> > But if remove it it should work.
> >
> > The AC_CHECK_LIB(rpc, innetgr, LIBS="-lrpc -lyp -lrpc $LIBS" , ,
> > -lyp -lrpc)
> > test should fail on anything other than SCO Open Server 3
>
> It not complicated enough. If I underand it right it will add the
> loading of rpc and yp if if finds a rpc lib.   Cray have a rpc
> lib so it adds both rpc and yp to the load list which is bad
> since cray don't have a yp lib.

If Cray passes that test without having libyp it's broken.
Wendy's patch is suposed to correct this so it will properly fail
on that test.

Unless I hear someone say "I've added Wendy's configure.in patch and
it still adds -lrpc -lyp to LIBS" I'm going to commit the patch.

>
> Why can't this just be removed and the extra lib just be added
> to the LIB definition in the target-specific stuff for sco?
>
>
> >
> > > and I can still get errors because I don't have libyp.a.
> > As you should.
> >
> > >
> > > My solution works!
> > >
> > > A better solution is to have the offinding code check for both
> > rpc and yp
> > > lib before add them.
> > >
> > > Or just alway look for rpc and add it.  Then look for yp and add it.
> >
> > Are you saying you need to link in librpc to get openssh to work?
> >
> > >
> > > Just don't assume that yp exist if rpc does.
> > >
> > > How do you think the problem should be solved?
> > >
> > > BIll Jones
> > >
> > > > -----Original Message-----
> > > > From: Tim Rice [mailto:tim at multitalents.net]
> > > > Sent: Monday, August 06, 2001 1:06 PM
> > > > To: William L. Jones
> > > > Subject: Re: Cray patch against openssh-SNAP-20010802
> > > >
> > > >
> > > > On Sun, 5 Aug 2001, William L. Jones wrote:
> > > >
> > > > > I look and see.  Is her patch in the daily drop yet?
> > > >
> > > > Not yet. I was about to add it when I saw your message.
> > > > Please try the small patch below and let me know.
> > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > From: "Tim Rice" <tim at multitalents.net>
> > > > > To: "William L. Jones" <jones at mail.utexas.edu>
> > > > > Cc: <openssh-unix-dev at mindrot.org>
> > > > > Sent: Sunday, August 05, 2001 7:06 PM
> > > > > Subject: Re: Cray patch against openssh-SNAP-20010802
> > > > >
> > > > >
> > > > > > On Thu, 2 Aug 2001, William L. Jones wrote:
> > > > > >
> > > > > > > Significant changes since last patch.
> > > > > > >
> > > > > > [snip]
> > > > > > >
> > > > > > > Add no_sco flag to noop check for -lrpc which assumes that
> > > > > > > their was a -lyp library.
> > > > > >
> > > > > > Did Wendy's patch not fix your -lyp problem?
> > > > > > ....
> > > > > >
> > > > > > % diff -u configure.in.orig configure.in
> > > > > > --- configure.in.orig   Wed Aug  1 16:24:39 2001
> > > > > > +++ configure.in        Wed Aug  1 16:40:40 2001
> > > > > > @@ -245,7 +245,7 @@
> > > > > >          no_libsocket=1
> > > > > >          no_libnsl=1
> > > > > >         AC_DEFINE(USE_PIPES)
> > > > > > -       LDFLAGS="$LDFLAGS -L/usr/local/lib"
> > > > > > +       LDFLAGS="$LDFLAGS
> > -Wl,-Dmsglevel=334:fatal",-L/usr/local/lib"
> > > > > >          LIBS="$LIBS -lgen -lrsc"
> > > > > >          ;;
> > > > > >  *-dec-osf*)
> > > > > >
> > > > > >
> > > > > > --
> > > > > > wendy palm
> > > > > > Cray OS Sustaining Engineering, Cray Inc.
> > > > > > wendyp at cray.com, 651-605-9154
> > > > > > ....
> > > > > >
> > > > > > >
> > > > > > [snip]
> > > >
> > > > --
> > > > Tim Rice				Multitalents	(707) 887-1469
> > > > tim at multitalents.net
> > > >
> > > >
> > >
> >
> > --
> > Tim Rice				Multitalents	(707) 887-1469
> > tim at multitalents.net
> >
> >
>

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net