OpenSSH 2.4?

[mouring at etoh.eviladmin.org]

On Sat, 3 Feb 2001, Gert Doering wrote:

> Hi,
> 
> On Sat, Feb 03, 2001 at 05:08:40PM +0100, Gert Doering wrote:
> > > Don't forget the test -S problem.
> > 
> > Just tried openssh_cvs "up-to-date" on SCO 3.2v4.2, and "test -S" is still
> > there... (configure redone by "autoconf" after "cvs update -d").
> 

No one has given me an acceptable replace for 'test -S'... So I'm not
personally inclined to muck with it.=)

> To followup on myself:
> 
>  - openbsd-compat/strtok.c includes "bsd-strtok.h" but the file is 
>    called "strtok.h" -> renaming to bsd-strtok.h makes it compile
>    (but breaks openbsd-compat.h, which includes "strtok.h").
> 

The last two  bsd-* in the openbsd-compat/ should be resolved.  ( I just
submitted it)

>  - configure fails to detect HAVE_CLOCK_T, which leads to compiler
>    warnings - harmless, but looks scary :-) 
> 

Did this fail before?  I've not seen HAVE_CLOCK_T issues on any of my
machine for a while.

> 
>  - Makefile contains the line:
> 
>     $(LIBOPENBSD_COMPAT_OBJS): config.h
> 
>    which makes SCO make choke, as LIBOPENBSD_COMPAT_OBJS is not defined.
> 
Fixed.

>  - openbsd-compat/Makefile contains a similar line:
> 
>     $(BSDCOMPAT): ../config.h
> 
>    which doesn't work either - I think it should be $(COMPAT) or
>    $(OPENBSD) - maybe both.   [With GNU make, both are ignored]
> 
Should be both.. in an earier version of this change over I had grouped
everything together, but later decided that it would make more sense to
split them.  It gives you another place to realize what is OpenBSD based
source code, and home-brewed stuff.

>  - compilation of "log.c" with "gcc -g -O2" (gcc 2.7.2.3) breaks.  I can't 
>    see any obvious reason for this, though:
> 
> gcc -g -O2 -Wall -Dftruncate=chsize -I/usr/local/include -I/usr/local/ssl/include -I. -I./openbsd-compat -I. -DETCDIR=\"/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -DHAVE_CONFIG_H -c log.c
> In file included from defines.h:404,
>                  from config.h:681,
>                  from includes.h:22,
>                  from log.c:38:
> log.c: In function `log_facility_number':
> log.c:227: warning: implicit declaration of function `strcasecmp'
> /usr/tmp/cca13925.s:1007: FATAL:C_EFCN symbol out of scope
> gmake: *** [log.o] Error 1
> 
>     compiling without "-g" makes log.c compile just fine.  So maybe this
>     is something that just cannot be fixed without me upgrading my gcc :-)
> 
Don't know anything about that.  Sorry. Which GCC release?


> - linking ssh bombs out with:
> 
> gcc -o ssh ssh.o sshconnect.o sshconnect1.o sshconnect2.o log-client.o readconf.o clientloop.o -L. -Lopenbsd-compat/  -L/usr/local/lib -L/usr/local/ssl/lib -L/usr/local/ssl -lssh -lopenbsd-compat -lskey -lintl -lz -lsocket  -lgen -lsocket -los -lprot -lx -ltinfo -lm -lcrypto
> ld crtbegin.o: too many -L options, 6 allowed
> 
> which is fixed by removing "/usr/local/lib" (gcc inserts that anyway) and
> also "/usr/local/ssl" (the library is in /usr/local/ssl/lib).
> 
> - linking scp bombs with "unreferenced utimes()" - this has been discussed
>   before - what's the status of this?
> 
Hmm... utimes() was resolved a while ago.

20010115
 - (bal) utimes() support via utime() interface on machine that lack
utimes().

openbsd-compat/bsd-misc.c:int utimes(char *filename, struct timeval *tvp)

Are you sure you regenerated your 'configure'?   Do a './configure | grep
utimes' and see wh

> ... after hacking all these things, ssh, sshd & co compile and link fine.  
> This means you've done very good work on the portability side - SCO 3.0 
> is *old*, and very "different".
> 
> Can't comment on "work" yet, will test now...
> 


- Ben