OpenSSH 2.5.0p1

mouring at etoh.eviladmin.org mouring at etoh.eviladmin.org
Sat Feb 17 15:46:10 EST 2001


On Sat, 17 Feb 2001, Damien Miller wrote:

> On Fri, 16 Feb 2001 mouring at etoh.eviladmin.org wrote:
> 
> > 
> > On Sat, 17 Feb 2001, Damien Miller wrote:
> > > On Fri, 16 Feb 2001 mouring at etoh.eviladmin.org wrote:
> > > > > Can we just detect [ $(srcdir) = "." ] and not do the -I?
> > > > 
> > > > That was my thought.  But I was not sure if it would go into configure.in
> > > > or the Makefile.in file.
> > > 
> > > Here is a patch that does this. Unfortunately as Gert pointed out, this
> > > doesn't fix it for the builddir != srcdir case.
> > > 
> > 
> > May I suggest a smaller patch.  Instead of assuming that we can do both
> > AIX and builddir != srcdir.  Lets value the platform support over the
> > latter case and enable builddir != srcdir via a ./configure option.  
> 
> You need to pass a configure option to do builddir != srcdir anyway
> (--src-dir). Have you tested your patch with builddir != srcdir, I had
> to modify all the openbsd-compat stuff to get this working.
> 
> -d
> 

Yes I did test it.  It worked fine under Linux.  However I did not get any
chance to test it under anything else.   Before running ou the door.

I never needed --src-dir to compile in a different location.  But if that
is needed then we should set the right -I via that if we can.  Because we
have other issues that are more hidden (pty.h and openpty() call).

Tim,

The choice is either we ignore AIX or we stop the default behavior of
building out of the tree.  Where the latter is anonying the form is
unacceptable.

- Ben






More information about the openssh-unix-dev mailing list