X11 display issues

Wendy Palm wendyp at cray.com
Fri Feb 23 06:06:22 EST 2001


along these lines, please add this patch to define a new define for all the
systems who don't allow unix sockets (and some defines i need for the cray port
anyway) (thanks to bill for writing them & sending them to me in the first
place).  i've got more patches for cray, but will send them slowly to make sure
we don't break too much all at once (and please let me know if i send things
incorrectly.)

Index: openssh_cvs/defines.h
===================================================================
RCS file: /cvs/openssh_cvs/defines.h,v
retrieving revision 1.55
diff -r1.55 defines.h
141c141,145
< #  error "16 bit int type not found."
---
> #  ifdef _CRAY
> typedef long  int16_t;
> #  else
> #   error "16 bit int type not found."
> #  endif /* _CRAY */
145a150,152
> #  ifdef _CRAY
> typedef long  int32_t;
> #  else
146a154
> #  endif /* _CRAY */
166c174,178
< #   error "16 bit int type not found."
---
> #   ifdef _CRAY
> typedef unsigned long  u_int16_t;
> #   else
> #    error "16 bit int type not found."
> #   endif
171c183,187
< #   error "32 bit int type not found."
---
> #   ifdef _CRAY
> typedef unsigned long  u_int32_t;
> #   else
> #    error "32 bit int type not found."
> #   endif
398a415,421
> #endif
> 
> /*
>  * Some systems don't allow unix sockets with X11.
>  */
> #if defined(HAVE_CYGWIN)||defined(_CRAY) /* Unix sockets are not supported */
> #define NO_X11_UNIX_SOCKETS

Index: session.c
===================================================================
RCS file: /cvs/openssh_cvs/session.c,v
retrieving revision 1.82
diff -r1.82 session.c
1369c1369
< #ifndef HAVE_CYGWIN /* Unix sockets are not supported */
---
> #ifndef NO_X11_UNIX_SOCKETS
1375c1375
< #endif
---
> #endif /* NO_X11_UNIX_SOCKETS */
1383c1383
< #ifndef HAVE_CYGWIN /* Unix sockets are not supported */
---
> #ifndef NO_X11_UNIX_SOCKETS
1388c1388
< #endif
---
> #endif /* NO_X11_UNIX_SOCKETS */



"William L. Jones" wrote:
> 
> Keep the Internet domain sockets at least for a few systems.   Cray
> UNICOS  X11 does not support unix domain sockets.
> 
> Do both but configure unix domain sockets by default at let porters add a
> define to
> do Internet domain sockets instead of unix domain sockets.
> 
> Bill Jones
> 
> At 04:13 PM 2/21/01 +0100, Markus Friedl wrote:
> >On Wed, Feb 21, 2001 at 04:03:18PM +0100, Andy Polyakov wrote:
> > > This also has been discussed in SSHSCI's SSH context. All SSH versions
> > > (both SSHSCI and OpenSSH) derive value for DISPLAY variable from
> > > `uname -n`. The problem is that the returned value is not necessarily
> > > resolvable to a valid IP number which in turn might cause a failure.
> >
> >oh yes, this is a problem. i will probably change the sshd-X11-proxy
> >from internet to unix domain sockets.
> >
> >libX is broken if i set DISPLAY=localhost:x.y and ignore any
> >X cookies.
> >
> > > To make it fool-proof I suggest to set DISPLAY to the interface's
> > > address the user has reached the system in question through.
> >
> >I tried this before, but it does not work since it uses AF_INET6 if
> >i connect by
> >         $ ssh -X ::1
> >
> >so it's not really acceptible. I'm still looking for a better
> >solution...
> >
> >-markus

-- 
wendy palm
Cray OS Sustaining Engineering, Cray Inc.
wendyp at cray.com, 651-605-9154





More information about the openssh-unix-dev mailing list