configure: sense of --enable-utmpx test et al. reversed

Buck Huppmann buckh at pobox.com
Wed Jul 18 10:15:05 EST 2001


it seems that --enable-utmpx and friends have the effect of disabling
the corresponding feature (i.e., #define-ing DISABLE_UTMPX etc.), which
leads to the (perhaps not so) obvious breakage of UseLogin on Solaris
etc. For the less anal (or reformed anal) configure-r who leaves these
unspecified, everything is OK

i'd suggest changes to configure.in, but i'm blissfully ignorant of
autoconf. suffice it to say, despite the help text arguments, these
macro invocations seem suspect:

^dnl allow user to disable some login recording features
AC_ARG_ENABLE(lastlog,
        [  --disable-lastlog       disable use of lastlog even if detected [no]],
        [ AC_DEFINE(DISABLE_LASTLOG) ]
)
AC_ARG_ENABLE(utmp,
        [  --disable-utmp          disable use of utmp even if detected [no]],
        [ AC_DEFINE(DISABLE_UTMP) ]
)
AC_ARG_ENABLE(utmpx,
        [  --disable-utmpx         disable use of utmpx even if detected [no]],
        [ AC_DEFINE(DISABLE_UTMPX) ]
)

etc.

other than this complaint (assuming it's valid and that i'm not crocked),
i'm an immensely satisfied customer--thanks very much, folks



More information about the openssh-unix-dev mailing list