forwarded message from mouring at etoh.eviladmin.org

Markus Friedl Markus.Friedl at informatik.uni-erlangen.de
Tue Jul 24 17:56:22 EST 2001


On Tue, Jul 24, 2001 at 05:25:04AM +0200, Marcus Brinkmann wrote:
> Hi,
> 
> On Mon, Jul 23, 2001 at 08:55:53PM +0200, Markus Friedl wrote:
> > this patch looks fine,
> > 
> > however, i don't want to see a magic numer 401 in openssh's code.
> 
> I can understand that.  This is why I suggested to put a wrapper around
> gethostname which just xmallocs/xreallocs a large enough buffer, and use
> this wrapped version everywhere were gethostname is used right now.
> 
> An implementation is already part of the original patch, if I recall
> correctly, and just needs to be isolated into a function.
> 
> If you prefer it this way (and personally, I do), we can rework the
> whole patch and submit it to you for review. (of course if you want to do
> this yourself, we are fine with that!).
> 
> > why not just define MAXHOSTNAMELEN for HURD ?
> 
> One main goal of the Hurd is to not impose any arbitrary system limit on the
> users.  The system code should be as flexible as possible so it does not

i was not talking about your system. our headers could do the same.



More information about the openssh-unix-dev mailing list