forwarded message from mouring at etoh.eviladmin.org

Robert Bihlmeyer robbe at orcus.priv.at
Tue Jul 24 19:41:40 EST 2001


Markus Friedl <markus.friedl at informatik.uni-erlangen.de> writes:

> however, i don't want to see a magic numer 401 in openssh's code.

Well, there's already a magic number in the same file (channel.c)
Lines 2271-2273:

	/* Just set DISPLAY to hostname:screen.display */
	snprintf(display, sizeof display, "%.400s:%d.%d", hostname,
		 display_number, screen_number);

It may be good to "#define DISPLAY_MAXHOSTLEN 400" somewhere.

> why not just define MAXHOSTNAMELEN for HURD ?

#ifndef MAXHOSTNAMELEN
#define MAXHOSTNAMELEN 256
#endif

somewhere in openssh's code would be fine with us. We would like the
other alternatives better, of course.

-- 
Robbe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.ng
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20010724/9b05a7d6/attachment.bin 


More information about the openssh-unix-dev mailing list