make 2.5.1p1 on Solaris8 (fwd)

[Andrew Stribblehill]

Quoting Damien Miller <djm at mindrot.org>:
> Can a Solaris person take a look at this?
> 
> -- 
> | Damien Miller <djm at mindrot.org> \ ``E-mail attachments are the poor man's
> | http://www.mindrot.org          /   distributed filesystem'' - Dan Geer
> 
> ---------- Forwarded message ----------
> Date: Wed, 28 Feb 2001 12:33:48 +0200
> From: owner-ssh at clinet.fi
> To: ssh at clinet.fi
> Subject: make 2.5.1p1 on Solaris8
> 
> Trying to build 2.5.1p1 on Solaris 8 x86 with patches from 01/01:
> 
> gcc -g -O2 -Wall -I/opt/include -I/opt/include/openssl -I/usr/local/include
> -I/o
> pt/include -I/opt/include -I. -I./openbsd-compat -I.
> -DETCDIR=\"/etc/opt/ssh\" -
> D_PATH_SSH_PROGRAM=\"/opt/openssh/bin/ssh\"
> -D_PATH_SSH_ASKPASS_DEFAULT=\"/opt/o
> penssh/libexec/ssh-askpass\"
> -D_PATH_SFTP_SERVER=\"/opt/openssh/libexec/sftp-ser
> ver\" -DHAVE_CONFIG_H -c scp.c
> scp.c: In function `foregroundproc':
> scp.c:1124: too many arguments to function `getpgrp'
> make: *** [scp.o] Error 1


Well, the Solaris 8 manpage says that getpgrp takes no arguments.
My guess is that GETPGRP_VOID is not being defined so the macro
  #define getpgrp() getpgrp(0)
is being used. This would point to a bug in autoconf, specifically
in the AC_FUNC_GETPGRP macro.

To confirm my guess, look in config.h for the line
  #define GETPGRP_VOID 1

Note: I don't get this problem with Solaris 8 (Sparc) on CVS as of
a week ago.

Cheerio,

Andrew Stribblehill
Systems programmer, IT Service, University of Durham England