"-v" handling in scp (was Re: add scp path to _PATH_STDPATH)

mouring at etoh.eviladmin.org mouring at etoh.eviladmin.org
Mon Mar 5 07:09:23 EST 2001


> ishikawa at duron$ rcsdiff -c scp.c
> ===================================================================
> RCS file: RCS/scp.c,v
> retrieving revision 1.1
> diff -c -r1.1 scp.c
> *** scp.c       2001/03/04 18:35:17     1.1
> --- scp.c       2001/03/04 18:46:21
> ***************
> *** 277,283 ****
>                         ssh_program = xstrdup(optarg);
>                         break;
>                 case 'v':
> !                       verbose_mode = 1;
>                         break;
>                 case 'q':
>                         showprogress = 0;
> --- 277,284 ----
>                         ssh_program = xstrdup(optarg);
>                         break;
>                 case 'v':
> !                       verbose_mode ++; /* for remote  */
> !                       addargs("-v"); /* for local ssh */
>                         break;

			if ( verbose_mode < 3) {
				verboase_mode++;
				addargs("-v");
			} else
				fatal("Too high debugging level.");

Would be better because your patch accepts unlimited -v, but only honors
the first three.

- Ben







More information about the openssh-unix-dev mailing list