2.9p1 ssh-add/ssh-askpass first try fails

[John Dunlap]

Yup -- that does it -- Thanks, John
P.S.,  Thanks to all the developers.

> 
> On Thu, 10 May 2001, John Dunlap wrote:
> 
> > OpenSSH Version 2.9p1 of "ssh-add $HOME/.ssh/id_rsa < /dev/null"
> > fails on the first try of using ssh-askpass before the window manager
> > starts.  The second try works.  The error message on the first try is
> > "Bad passphrase, try again".
> 
> Does this help?
> 
> Index: readpass.c
> ===================================================================
> RCS file: /var/cvs/openssh/readpass.c,v
> retrieving revision 1.13
> diff -u -r1.13 readpass.c
> --- readpass.c	2001/05/02 01:30:33	1.13
> +++ readpass.c	2001/05/10 22:57:44
> @@ -69,7 +69,7 @@
>  		fatal("ssh_askpass: exec(%s): %s", askpass, strerror(errno));
>  	}
>  	close(p[1]);
> -	len = read(p[0], buf, sizeof buf);
> +	len = atomicio(read, p[0], buf, sizeof buf);
>  	close(p[0]);
>  	while (waitpid(pid, &status, 0) < 0)
>  		if (errno != EINTR)
> 
> -d
> 
> -- 
> | Damien Miller <djm at mindrot.org> \ ``E-mail attachments are the poor man's
> | http://www.mindrot.org          /   distributed filesystem'' - Dan Geer
> 


-- 
John Dunlap                           University of Washington
Senior Electrical Engineer            Applied Physics Laboratory
dunlap at apl.washington.edu             1013 NE 40th Street
206-543-7207, 543-1300, FAX 543-6785  Seattle, WA   98105-6698