OpenSSH-3.0p1-pre-CVS: configure.ac checks for login in -lutil and -lbsd?

Tim Rice tim at multitalents.net
Fri Nov 2 04:33:22 EST 2001


On Thu, 1 Nov 2001, Mark D. Roth wrote:

> On Tue Oct 30 20:10 2001 -0800, Tim Rice wrote:
> > @@ -619,7 +616,13 @@
> >  AC_CHECK_FUNCS(gettimeofday time)
> >  dnl    Checks for libutil functions
> >  AC_CHECK_HEADERS(libutil.h)
> > -AC_CHECK_FUNCS(login logout updwtmp logwtmp)
> > +AC_CHECK_FUNC(login,
> > +	[AC_DEFINE(HAVE_LOGIN)],
> > +	[AC_CHECK_LIB(util, login, AC_DEFINE(HAVE_LOGIN) LIBS="$LIBS -lutil",
> > +	[AC_CHECK_LIB(bsd, login, [LIBS="$LIBS -lbsd"; AC_DEFINE(HAVE_LOGIN)])]
> > +	)]
> > +)
> > +AC_CHECK_FUNCS(logout updwtmp logwtmp)
> >  dnl    Checks for utmp functions
> >  AC_CHECK_FUNCS(endutent getutent getutid getutline pututline setutent)
> >  AC_CHECK_FUNCS(utmpname)
>
> Just a minor stylistic comment: Wouldn't it be a bit cleaner to just
> use this?
>
>   AC_SEARCH_LIBS(login, util bsd, [AC_DEFINE(HAVE_LOGIN)])

Yes it would be cleaner. Thanks.
(Maybe it's time to post a list of macros on the wall) :-)

I'll commit these changes this weekend unless I hear it breaks somewhere.

>
> Of course, if I'm missing something, feel free to flog me with a large
> trout... ;)
>
>

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net





More information about the openssh-unix-dev mailing list