bug in scp (OpenSSH)

[Markus Friedl]

On Tue, Sep 04, 2001 at 06:40:14PM +0200, Harald Koenig wrote:
> On Aug 31, Markus Friedl wrote:
> 
> > On Fri, Aug 31, 2001 at 12:20:23PM +0200, Roman Drahtmueller wrote:
> > > Are you serious that you want to keep a bug because "this is how the rcp
> > > protocol works"? It is clearly flawed.
> > 
> > should we really change the semantics of a 17 year old protocol,
> > if you can use sftp, rsync or tar instead?
> 
> if behaviour is broken and it's not explicitly designed to be broken
> that way: yes.  (and it _is_ broken).
> 
> I tried "rcp" too and indeed, it does copy binary trash too.
> fortuneately, at least with my ~8 kbytes source file, no
> passwd entries show up in rcp buffers but only parts of
> /etc/services.  but who knows what might show up for longer source
> files ?!
> 
> 
> > however, you can try to modify sink() to truncate the ofd if
> > response() returns an error. so the data will be sent but
> > discarded. i'm not sure whether i like the idea. it might
> > break other things.
> 
> your 2nd patch below doesn't make any difference.
> destination file still gets filled with null bytes.

you did update scp on both sides?