openssh-2.9p2: --with-pid-dir does not work?

[Kalin Kozhuharov]

Hello!
I was trying to configure/install the latest openssh-2.9p2 with some not 
very traditional layout and the configure script didn't make it properly.

I was trying to:
./configure \
         --prefix=/opt/openssh \
         --sysconfdir=/etc/opt/openssh \
         --with-pid-dir=/var/opt/openssh/run \
         --with-ssl-dir=/opt/openssl

But instead the MakefileS read:
...
piddir=/etc/opt/openssh
...

I could reproduce the bug several times on one Debian box, I think the 
system is not important here. This issue was addressed before in 2.9p1 
and some code was corrected as I see, but still is not working.
I looked through some source code, but I couldn't spot the bug :(

How I manually fixed it:
1. Run ./configure as above
2. Edit ./Makefile & ./openbsd-compat/Makefile to say
  piddir=Your/Pid/dir
3. Edit ./config.h to say
  #define _PATH_SSH_PIDDIR "/Your/Pid/dir"

4. Continue with normal
  make
  make install
*** in .contrib/solaris/build-pkg script there is a reference to 
../../Makefile ***
**** I got just one insignificant warning ****
***** I didn't get /var/opt/openssh/run directory created! *****

Now at my 5th (or was it 7th) rebuild I did everything almost correct. 
And having spent so much time, may be I should have fixed the default 
path in Makefile.in and live with it? But this is not the programmers 
way, right?
Now just have to set it up, ha!

If you reply to this, please send cc to my e-mail as well!

Kalin Kozhuharov

-- 
||///_ o  *******************************
||//,_/>   WWW:     http://ThinRope.Net/
|||\ <"
|||\\ '   *******************************