[Bug 199] New: ssh-agent -k doesn't check $SHELL environment variable

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=199

           Summary: ssh-agent -k doesn't check $SHELL environment variable
           Product: Portable OpenSSH
           Version: 3.1p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: ssh-agent
        AssignedTo: openssh-unix-dev at mindrot.org
        ReportedBy: menscher+bug at uiuc.edu
                CC: menscher+bug at uiuc.edu


Line 882 of ssh-agent.c reads:
if (ac == 0 && !c_flag && !k_flag && !s_flag && !d_flag) {
   stuff to set c_flag=1 iff $SHELL=*csh
}

This means that someone running ssh-agent -k will have k_flag set and therefore 
won't get the auto-shell determination, therefore leaving them with bash-style 
commands.

I'm guessing the debug flag shouldn't be here either, so the correct line would 
read:
if (ac == 0 && !c_flag && !s_flag) {

This was originally found to be broken on IRIX 6.5.15m, but looking at the 
source made it obvious it was cross-platform.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.