privsep no user fatal message

Pekka Savola pekkas at netcore.fi
Thu Apr 18 23:36:00 EST 2002


Hello,

I updated the latest snapshot as RPM's to two of my systems.  Basic stuff 
seems to be working ok.

Privilege separation failed though, possibly because I didn't populate 
/var/empty with PAM entries.  Privsep might be a bit raw in any case, at 
least for the portable.

FWIW, I came across error message 'sshd: no user' and had to scratch my 
head a bit to figure out what it meant.  I suggest changing the order to 
be more in sync with other similar code paths.  Patch attached.

-- 
Pekka Savola                 "Tell me of difficulties surmounted,
Netcore Oy                   not those you stumble over and fall"
Systems. Networks. Security.  -- Robert Jordan: A Crown of Swords
-------------- next part --------------
Index: sshd.c
===================================================================
RCS file: /cvs/openssh/sshd.c,v
retrieving revision 1.200
diff -u -r1.200 sshd.c
--- sshd.c	2 Apr 2002 20:48:20 -0000	1.200
+++ sshd.c	18 Apr 2002 13:36:04 -0000
@@ -536,7 +536,7 @@
 	demote_sensitive_data();
 
 	if ((pw = getpwnam(SSH_PRIVSEP_USER)) == NULL)
-		fatal("%s: no user", SSH_PRIVSEP_USER);
+		fatal("no user: %s", SSH_PRIVSEP_USER);
 	memset(pw->pw_passwd, 0, strlen(pw->pw_passwd));
 	endpwent();
 


More information about the openssh-unix-dev mailing list