sshd doesn't log hostname into utmp correctly [resend]

Kevin Steves stevesk at pobox.com
Sat Dec 28 07:32:33 EST 2002


On Fri, Dec 13, 2002 at 11:37:11PM +0900, Hajimu UMEMOTO wrote:
> kevin> yes i agree, we should add your fix.  thanks again.
> 
> Thank you for merging the patch.  However, I realized that
> unfortunately the merging is incomplete, and 3.5p1 still has the
> problem.  Please apply the attached patch in your next release.
> 
> Index: sshlogin.c
> diff -u sshlogin.c.orig sshlogin.c
> --- sshlogin.c.orig	Wed Sep  4 15:45:11 2002
> +++ sshlogin.c	Fri Dec 13 16:42:17 2002
> @@ -70,7 +70,7 @@
>    struct logininfo *li;
>  
>    li = login_alloc_entry(pid, user, host, ttyname);
> -  login_set_addr(li, addr, sizeof(struct sockaddr));
> +  login_set_addr(li, addr, addrlen);
>    login_login(li);
>    login_free_entry(li);
>  }

is that the only missing piece?  i thought there was more?
record_utmp_only()?

  - stevesk at cvs.openbsd.org 2002/08/29 15:57:25
     [monitor.c session.c sshlogin.c sshlogin.h]
     pass addrlen with sockaddr *; from Hajimu UMEMOTO <ume at FreeBSD.org>
     NOTE: there are also p-specific parts to this patch. ok markus@



More information about the openssh-unix-dev mailing list