x509 test patch - can't compile

[Markus Friedl]

On Thu, Feb 14, 2002 at 09:35:53AM -0500, Ed Phillips wrote:
> It's line 741 of key.c in 3.0.2p1 with the x509 patch (that Markus posted
> a couple weeks ago) applied.  The call to buffer_append_space has the
> wrong number of args:
> 
>         case KEY_RSA:
>                 if (key->x509) {
>                         /* XXX ssh.com does not accept a key name here */
>                         len = i2d_X509(key->x509, NULL);
> -->                     buf = buffer_append_space(&b, len);

try to change this to 

			buffer_append_space(&b, &buf, len);

>                         i2d_X509(key->x509, &buf);
>                 } else {
>                         buffer_put_cstring(&b, key_ssh_name(key));
>                         buffer_put_bignum2(&b, key->rsa->e);
>                         buffer_put_bignum2(&b, key->rsa->n);
>                 }
> 
> 
> What's the correct way to fix this?  It seems to be a departure from the
> "cram stuff into b" mentality that the surrounding code is doing...
> 
> By the way, Markus, does this patch include code to make the OpenSSH
> client verify the server's host key with x509, or does this just patch

no.

> just make the server tack on the x509 stuff so that SSH.COM's client could
> use it?

yes.