suggested fix for the sigchld race

[Nicolas Williams]

On Fri, Jan 25, 2002 at 06:13:14PM +0100, Markus Friedl wrote:
> On Fri, Jan 25, 2002 at 12:07:56PM -0500, Nicolas Williams wrote:
> > On Wed, Oct 31, 2001 at 05:42:01PM +0100, Markus Friedl wrote:
> > > comments?
> > 
> > Works. The SIGCHLD/select() race is still present in 3.0.2p1. This
> > patch should be applied.
> 
> wow! finally feedback on this. please check current snapshots,
> it's already beed added.

Sorry for the delay. I'd like to play with releases of and patches to
OpenSSH and other opensource stuff as they come out. But I can't
always.

> > sigsetjmp() is not ugly (this is the sort of problem it's meant to be
> > there for). But it's not as elegant as the pipe trick and probably much
> > less portable. I prefer the the pipe trick.
> 
> sigsetjmp() is ugly as hell. think about correctly releasing resources.

Whatever - I'm not advocating it :)

> > So I second the use of the pipe trick to prevent the SIGCHLD/select()
> > race condition.
> > 
> > I'll file a bug report.
> 
> what bug report?

Bug 79 on http://bugzilla.mindrot.org/ :)

Cheers,

Nico
--
-DISCLAIMER: an automatically appended disclaimer may follow. By posting-
-to a public e-mail mailing list I hereby grant permission to distribute-
-and copy this message.-

Visit our website at http://www.ubswarburg.com

This message contains confidential information and is intended only 
for the individual named.  If you are not the named addressee you 
should not disseminate, distribute or copy this e-mail.  Please 
notify the sender immediately by e-mail if you have received this 
e-mail by mistake and delete this e-mail from your system.

E-mail transmission cannot be guaranteed to be secure or error-free 
as information could be intercepted, corrupted, lost, destroyed, 
arrive late or incomplete, or contain viruses.  The sender therefore 
does not accept liability for any errors or omissions in the contents 
of this message which arise as a result of e-mail transmission.  If 
verification is required please request a hard-copy version.  This 
message is provided for informational purposes and should not be 
construed as a solicitation or offer to buy or sell any securities or 
related financial instruments.