[PATCH] Added NoDelay config option and nodelay subsystem option

mouring mouring at etoh.eviladmin.org
Tue Jan 29 12:55:44 EST 2002


[..]
> My overlapping reads/writes for sftp seems to be ignored at the moment.
> 
> I'm not happy.
> 
> /Tobias
> 
One thing you must learn Tobias, unless things are clear cut as 'THE WAY'
to go there is (and more than likely ever will be) a long period in time
from patch conception to inclusion.  And this is one in which is not
100% clear cut.  Between NoDelay, COPY_SIZE, how many overlapping
segments, and if we should let the user muck with them are all things that
will affect how we accept the patch.

I'm still waiting for you to provide any information on upping COPY_SIZE
to 32k and retesting with multiple overlapping.  I don't remember seeing
such an email messages.  However, this should also help lower the
amount of overlapping request.  As a result lower the cost of a missing
request. I don't want to get into the case where sftp thrashes due to 
multiple pending requests out and a bad link that drops 2 out of 5 packets. 
Which would not only cause large amount of seeks() but also could trigger
edge cases within the code for binary integerity. 

I don't have the patch infront of me..but there was some bits I did not
care for if I remember right.

- Ben



More information about the openssh-unix-dev mailing list