Quick sftp status indicator.

Damien Miller djm at mindrot.org
Wed Jan 30 12:11:26 EST 2002


On Tue, 29 Jan 2002, mouring wrote:

> I think my first send was eaten by elm.. Yuck I hate this programm..
> 
> Anyawys, first the disclaimer:
> 
> 	This is barely tests, I submit this to the general population, but
> 	I will not submit this for review of rest of the OpenSSH team.
> 	Mainly because it is horrible at best.  dealing with alarm() in
> 	a sane way is not fun.  It does not compile clean, but works.
> 	IF anyone cares to clean it up.. fine.
> 
> Issues:
> 
> 1) progressmeter() args are off, sftp-client.c arguments are unsigned 64bit.
> 
> 2) Had to globalize a few variables to use the current design of the
> indicator.
> 
> 3) It is from OpenBSD cvs tree... Therefor scp.c fails to patch right.  One
> has to manual patch it.
> 
> With that being said.. have fun..  BTW.. Embeded in this patch is another
> patch I submited to clean up handling the alocation of the progress bar.  

I'd prefer to see do_upload and do_download take a callback to handle
the progress meter. The stuff in sftp-client.[ch] should be protocol
related only - no UI.

-d





More information about the openssh-unix-dev mailing list