[Bug 338] X11 forwarding no longer works after upgrading from 2.9.9p2 to 3.4p1

[John R. Jackson]

>either way, let's figure out a fix/workaround for the next release
>because this is biting many people.  have autoconf bugs been filed?
>using 2.52 is not the right long-term answer.

Oh, fine. :-)  I spent another hour or so looking at the problem and
found a way around this at the autoconf level.

Bash has a problem with this construct:

  as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
  for as_dir in $PATH:/usr/X/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/openwin/bin
  do
    IFS=$as_save_IFS
    ...

The first thing I noticed was that ./configure is very carefully *not*
using ':' as the PATH separator (damned Windows machines :-).  That's one
problem that I'll bet *nobody* is thinking about (and is mis-documented
in the autoconf stuff).

The second problem (that I think is bash's fault) is that it's apparently
not expanding $PATH:x:y:z properly after the IFS change (as a guess).

In any case, the following patch appears to solve the problem on my
Solaris systems.  It should obviously undergo significant testing
elsewhere.

In addition to (hopefully) fixing the PATH problem, it removes
some odd looking code about explicitly setting xauth_path to
/usr/openwin/bin/xauth.  It shouldn't be needed if the other code is
working (maybe it was a previous workaround attempt to this problem?),
unless I misunderstood something (not that that ever happens :-).

Bash still doesn't work right on my systems (it reports a syntax error
running ./config.sub that you release from automake).  If I get a few
more minutes sometime I'll try to figure that one out, too.

JJ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 1411 bytes
Desc: autoconf-PATH-patch
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20020711/648fae7c/attachment.obj